[PATCH v5 4/4] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS

[Geert Uytterhoeven]

Hi Biju,

On Wed, Jul 3, 2024 at 10:56 AM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> > -----Original Message-----
> > From: Geert Uytterhoeven <geert at linux-m68k.org>
> > Sent: Wednesday, July 3, 2024 9:36 AM
> > Subject: Re: [PATCH v5 4/4] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS
> >
> > On Tue, Jul 2, 2024 at 8:01 PM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> > > Replace the fixed regulator for USB VBUS and use the proper one that
> > > controls regulator based on VBUS detection.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > > ---
> > > v4->v5:
> > >  * Updated commit description.
> >
> > Thanks for the update!
> >
> > > --- a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> > > @@ -54,14 +54,6 @@ codec_dai: simple-audio-card,codec {
> > >                 };
> > >         };
> > >
> > > -       usb0_vbus_otg: regulator-usb0-vbus-otg {
> > > -               compatible = "regulator-fixed";
> > > -
> > > -               regulator-name = "USB0_VBUS_OTG";
> > > -               regulator-min-microvolt = <5000000>;
> > > -               regulator-max-microvolt = <5000000>;
> > > -       };
> > > -
> > >         vccq_sdhi1: regulator-vccq-sdhi1 {
> > >                 compatible = "regulator-gpio";
> > >                 regulator-name = "SDHI1 VccQ"; @@ -139,6 +131,9 @@
> > > &ohci1 {
> > >
> > >  &phyrst {
> > >         status = "okay";
> > > +       usb0_vbus_otg: regulator-vbus {
> >
> > The label is not really needed, is it?
>
> The label is used in usb2_phy0 node.
>
> vbus-supply = <&usb0_vbus_otg>;

Oh right, that's a different node (too many USB-related nodes).
(my mind must have been mixing this up with the RZ/V2H SDHi regulator)

>
> >
> > > +               regulator-name = "vbus";
> > > +       };
> >
> > Also, as the regulator-vbus subnode is required, perhaps it should be moved to the SoC-
> > specific .dtsi? Or do you keep it here for board-specific control of the regulator name, i.e. to
> > avoid conflicts?
>
> Yes, just to avoid conflicts. Later I can move to individual SoC specific dtsi's

OK. Good to go(ne)...


Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds