[PATCH v5 4/4] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS

[Geert Uytterhoeven]

Hi Biju,

On Tue, Jul 2, 2024 at 8:01 PM Biju Das <biju.das.jz at bp.renesas.com> wrote:
> Replace the fixed regulator for USB VBUS and use the proper one that
> controls regulator based on VBUS detection.
>
> Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> ---
> v4->v5:
>  * Updated commit description.

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> @@ -54,14 +54,6 @@ codec_dai: simple-audio-card,codec {
>                 };
>         };
>
> -       usb0_vbus_otg: regulator-usb0-vbus-otg {
> -               compatible = "regulator-fixed";
> -
> -               regulator-name = "USB0_VBUS_OTG";
> -               regulator-min-microvolt = <5000000>;
> -               regulator-max-microvolt = <5000000>;
> -       };
> -
>         vccq_sdhi1: regulator-vccq-sdhi1 {
>                 compatible = "regulator-gpio";
>                 regulator-name = "SDHI1 VccQ";
> @@ -139,6 +131,9 @@ &ohci1 {
>
>  &phyrst {
>         status = "okay";
> +       usb0_vbus_otg: regulator-vbus {

The label is not really needed, is it?

> +               regulator-name = "vbus";
> +       };

Also, as the regulator-vbus subnode is required, perhaps it should
be moved to the SoC-specific .dtsi? Or do you keep it here for
board-specific control of the regulator name, i.e. to avoid conflicts?

>  };
>
>  &scif0 {

Anyway, this adheres to the DT bindings, so
Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds