[PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq

Andi Shyti andi.shyti at kernel.org
Sat Jan 27 13:53:36 PST 2024


Hi Thomas,

...

> -	struct pcs_device *pcs;
> -
> -	pcs = platform_get_drvdata(pdev);
> -	if (!pcs)
> -		return -EINVAL;
> +	struct pcs_device *pcs = dev_get_drvdata(dev);

I think this cleanup can be placed in a different patch. Besides,
it's not mentioned in the commit log.

Otherwise looks good.

Andi



More information about the linux-phy mailing list