[PATCH 13/14] PCI: j721e: move reset GPIO to device struct

Andy Shevchenko andy.shevchenko at gmail.com
Mon Jan 15 12:08:45 PST 2024


On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard at bootlin.com> wrote:
>
> From: Théo Lebrun <theo.lebrun at bootlin.com>
>
> Move reset GPIO to device struct, so it can be used at suspend and
> resume stages.

...

> -       struct gpio_desc *gpiod;

You can leave this and make the patch much lighter.

...

>                         if (ret != -EPROBE_DEFER)
>                                 dev_err(dev, "Failed to get reset GPIO\n");

Side note (not related to this change): perhaps dev_err_probe()?

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-phy mailing list