[PATCH] phy: renesas: rcar-gen3-usb2: Fix returning wrong error code
Geert Uytterhoeven
geert at linux-m68k.org
Fri Jan 5 02:25:36 PST 2024
On Fri, Jan 5, 2024 at 10:42 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh at renesas.com> wrote:
> Even if device_create_file() returns error code,
> rcar_gen3_phy_usb2_probe() will return zero because the "ret" is
> variable shadowing.
>
> Reported-by: kernel test robot <lkp at intel.com>
> Reported-by: Dan Carpenter <error27 at gmail.com>
> Closes: https://lore.kernel.org/r/202312161021.gOLDl48K-lkp@intel.com/
> Fixes: 441a681b8843 ("phy: rcar-gen3-usb2: fix implementation for runtime PM")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas at glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the linux-phy
mailing list