[PATCH 06/17] arm64: dts: exynos: gs101: Add the hsi2 sysreg node

Peter Griffin peter.griffin at linaro.org
Tue Apr 16 05:13:54 PDT 2024


Hi André,

Thanks for the review.

On Fri, 5 Apr 2024 at 08:33, André Draszik <andre.draszik at linaro.org> wrote:
>
> Hi Pete,
>
> On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote:
> > This has some configuration bits such as sharability that
> > are required by UFS.
> >
> > Signed-off-by: Peter Griffin <peter.griffin at linaro.org>
> > ---
> >  arch/arm64/boot/dts/exynos/google/gs101.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > index 38ac4fb1397e..608369cec47b 100644
> > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > @@ -1265,6 +1265,12 @@ cmu_hsi2: clock-controller at 14400000 {
> >                       clock-names = "oscclk", "bus", "pcie", "ufs_embd", "mmc_card";
> >               };
> >
> > +             sysreg_hsi2: syscon at 14420000 {
> > +                     compatible = "google,gs101-hsi2-sysreg", "syscon";
> > +                     reg = <0x14420000 0x1000>;
>
> Should the length not be 0x10000?

The downstream kernel uses a length of 0x1000 for all the
foobar-sysreg nodes, but checking the specs it does indeed seem that
the length should be 0x10000 (and that is what we've used for all the
other sysreg nodes upstream).

Will update this in v2.

regards,

Pete



More information about the linux-phy mailing list