[PATCH 02/31] phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void

Florian Fainelli f.fainelli at gmail.com
Tue Mar 7 08:56:24 PST 2023


On 3/7/23 03:58, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>
-- 
Florian




More information about the linux-phy mailing list