[PATCH] phy: starfive: make phys depend on HAS_IOMEM

Minda Chen minda.chen at starfivetech.com
Mon Jul 24 23:27:12 PDT 2023



On 2023/7/25 14:22, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> 
> Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> Reported-by: kernel test robot <lkp at intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> Signed-off-by: Vinod Koul <vkoul at kernel.org>
> ---
>  drivers/phy/starfive/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> index a560533a674e..ea82261ca818 100644
> --- a/drivers/phy/starfive/Kconfig
> +++ b/drivers/phy/starfive/Kconfig
> @@ -5,6 +5,7 @@
>  
>  config PHY_STARFIVE_JH7110_DPHY_RX
>  	tristate "StarFive JH7110 D-PHY RX support"
> +	depends on HAS_IOMEM
>  	select GENERIC_PHY
>  	select GENERIC_PHY_MIPI_DPHY
>  	help
> @@ -24,7 +25,7 @@ config PHY_STARFIVE_JH7110_PCIE
>  
>  config PHY_STARFIVE_JH7110_USB
>  	tristate "Starfive JH7110 USB 2.0 PHY support"
> -	depends on USB_SUPPORT
> +	depends on USB_SUPPORT && HAS_IOMEM
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the StarFive USB 2.0 PHY,
Hi Vinod

The USB_SUPPORT already depends on HAS_IOMEM.

menuconfig USB_SUPPORT
        bool "USB support"
        depends on HAS_IOMEM
        default y



More information about the linux-phy mailing list