[PATCH v3 2/5] phy: qcom-qmp-combo: add support for the USB+DP PHY on SM8150 platform

[Bjorn Andersson]

On Wed, May 31, 2023 at 02:16:42PM +0200, Konrad Dybcio wrote:
> 
> 
> On 31.05.2023 14:13, Dmitry Baryshkov wrote:
> > On Wed, 31 May 2023 at 14:35, Konrad Dybcio <konrad.dybcio at linaro.org> wrote:
> >> On 31.05.2023 04:34, Dmitry Baryshkov wrote:
> >>> SM8150 and SC8180X are close relatives. Reuse sc8180x data to support
> >>> USB+DP combo PHY on SM8150 platform.
> >>>
> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> >>> ---
> >> I'm not sure this is right. Downstream reuses SA8195 USB seq.
> > 
> > The upstream driver uses sm8150 data for sc8180x. So even if sc8180x
> > data is not correct for sc8180x, it is definitely the one that we
> > should use for sm8150:
> Right sorry, this patch adds support for 81*5*0. I wanted to point out
> that 8180 has a different set of init commands and one of them is probably
> incorrect.
> 

FWIW, DP works on my sc8180x devices. (But perhaps still not correct?)

Regards,
Bjorn