[PATCH 1/6] dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Sep 9 09:44:11 PDT 2022
On 09/09/2022 17:03, Dmitry Baryshkov wrote:
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 1
>>> + maxItems: 2
>>> + clock-names:
>>> + minItems: 1
>>> + items:
>>> + - const: slave_iface
>>> + - const: pxo
>>
>> Why pxo is optional? Commit msg does not say much here.
>
> It's optional as it is not present in current DT files. The driver will
> fallback to 'pxo_board' if the clock is not present.
>
>> It seems you also miss the DTS change adding the clock.
>
> Oh, I'll add it to v2.
How about adding it to DTS and making it required in the bindings? I did
not check the driver, but isn't the driver fail if clock is missing thus
the clock is really required?
Best regards,
Krzysztof
More information about the linux-phy
mailing list