[PATCH] phy: tegra: xusb: Fix crash during pad power on/down

Jon Hunter jonathanh at nvidia.com
Mon Nov 7 13:27:56 PST 2022


Hi Vinod,

On 17/10/2022 06:37, Vinod Koul wrote:
> On 10-10-22, 14:51, Jon Hunter wrote:
>> Commit a88520bfc0ec ("usb: gadget: tegra: Reduce pad power") added calls
>> to tegra_phy_xusb_utmi_pad_power_on/down in the Tegra XUDC driver to
>> control the pad power. This change is causing a kernel panic when
>> powering down the pads on entering suspend with the Jetson TX2 platform.
>> The panic occurs because the 'xudc->curr_utmi_phy' is not configured on
>> this platform and we do not check to see if the pointer is valid before
>> attempting to deference the pointer. Fix this by checking to see if the
>> 'phy' pointer passed to tegra_phy_xusb_utmi_pad_power_on/down is valid.
> 
> Applied, thanks
> 

We need this fix for Linux v6.1. The crash is still seen as of v6.1-rc3.

Thanks
Jon

-- 
nvpublic



More information about the linux-phy mailing list