ARMADA espressobin SATA drive detection failure

[Shinichiro Kawasaki]

Hello Pali, Marek,

I have an ARMADA espressobin board, and I'm setting up SATA drive test
environment on it. Using that board, I observe that SATA drives are not
detected after merging two commits [1]. They were merged in the kernel at
v5.18-rc1. With v5.17 kernel, the SATA drives were successfully detected.
Reverting the commits from v5.18, SATA drives can be detected.

[1] ee995101fde6 ("Revert "ata: ahci: mvebu: Make SATA PHY optional for Armada 3720"")
    934337080c6c ("phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation")

FYI, here I share related kernel messsages:

$ dmesg | grep -e ata -e mvebu
[    4.007130] ahci-mvebu d00e0000.sata: supply ahci not found, using dummy regulator
[    4.014963] ahci-mvebu d00e0000.sata: supply phy not found, using dummy regulator
[    4.022596] ahci-mvebu d00e0000.sata: supply target not found, using dummy regulator
[    4.031123] ahci-mvebu d00e0000.sata: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl platform mode
[    4.040180] ahci-mvebu d00e0000.sata: flags: ncq sntf led only pmp fbs pio slum part sxs 
[    4.050150] scsi host0: ahci-mvebu
[    4.053949] ata1: SATA max UDMA/133 mmio [mem 0xd00e0000-0xd00e0177] port 0x100 irq 30
[    4.388934] ata1: SATA link down (SStatus 0 SControl 300)
[    5.239165] EXT4-fs (mmcblk0p1): mounted filesystem with ordered data mode. Quota mode: none.
[   10.751378] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   45.727407] ata1: SATA link down (SStatus 100 SControl 300)   (... I connected a drive to the SATA port)
[   46.497413] ata1: SATA link down (SStatus 100 SControl 300)
[   47.267411] ata1: SATA link down (SStatus 100 SControl 300)
[   48.047412] ata1: SATA link down (SStatus 100 SControl 300)
[   48.827416] ata1: SATA link down (SStatus 100 SControl 300)
[   49.597411] ata1: SATA link down (SStatus 100 SControl 300)
[   50.577414] ata1: SATA link down (SStatus 100 SControl 300)
[   51.357409] ata1: SATA link down (SStatus 100 SControl 300)
[   52.587418] ata1: SATA link down (SStatus 100 SControl 300)
[   53.367419] ata1: SATA link down (SStatus 100 SControl 300)
[   54.147413] ata1: SATA link down (SStatus 100 SControl 300)
[   54.917412] ata1: SATA link down (SStatus 100 SControl 300)
[   55.697410] ata1: SATA link down (SStatus 100 SControl 300)
[   56.477411] ata1: SATA link down (SStatus 100 SControl 300)
[   57.247415] ata1: SATA link down (SStatus 100 SControl 300)
[   58.017413] ata1: SATA link down (SStatus 100 SControl 300)
[   58.797412] ata1: SATA link down (SStatus 0 SControl 300)     (... I removed the drive from the SATA port)

As shown above, the message: "ata1: SATA link down (SStatus 100 SControl 300)"
is repeated. It looks like the function mvebu_a3700_comphy_sata_power_on()
fails to set up SATA phy correctly, but I'm not sure how to investigate further.
Could you advise next action to fix this issue?

-- 
Shin'ichiro Kawasaki