[PATCH v4 1/4] dt-bindings: phy: qcom, qmp: Shift '#clock-cells' property to phy (child) node

Bhupesh Sharma bhupesh.sharma at linaro.org
Sun May 15 23:31:52 PDT 2022


Since the clock comes out of the phy (child) node,
so clocks are actually not provided by the parent device.
The qmp-phy dt-bindings specify the same incorrectly at
present. Fix the same.

This change helps fix the following 'make dtbs_check' warning(s):

sm8350-microsoft-surface-duo2.dt.yaml: phy at 1d87000:
  '#clock-cells' is a required property

Cc: Bjorn Andersson <bjorn.andersson at linaro.org>
Cc: Vinod Koul <vkoul at kernel.org>
Cc: Rob Herring <robh+dt at kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma at linaro.org>
---
 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 8b850c5ab116..c39ead81ecd7 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -66,9 +66,6 @@ properties:
       - description: Address and length of PHY's common serdes block.
       - description: Address and length of PHY's DP_COM control block.
 
-  "#clock-cells":
-    enum: [ 1, 2 ]
-
   "#address-cells":
     enum: [ 1, 2 ]
 
@@ -112,11 +109,13 @@ patternProperties:
     description:
       Each device node of QMP phy is required to have as many child nodes as
       the number of lanes the PHY has.
+    properties:
+      "#clock-cells":
+        enum: [ 0, 1, 2 ]
 
 required:
   - compatible
   - reg
-  - "#clock-cells"
   - "#address-cells"
   - "#size-cells"
   - ranges
@@ -468,7 +467,6 @@ examples:
     usb_2_qmpphy: phy-wrapper at 88eb000 {
         compatible = "qcom,sdm845-qmp-usb3-uni-phy";
         reg = <0x088eb000 0x18c>;
-        #clock-cells = <1>;
         #address-cells = <1>;
         #size-cells = <1>;
         ranges = <0x0 0x088eb000 0x2000>;
-- 
2.35.3




More information about the linux-phy mailing list