(EXT) [PATCH v2 0/7] Add the iMX8MP PCIe support

Wed Mar 9 18:03:54 PST 2022

> -----Original Message-----
> From: Alexander Stein <alexander.stein at ew.tq-group.com>
> Sent: 2022年3月9日 15:57
> To: Hongxing Zhu <hongxing.zhu at nxp.com>
> Cc: p.zabel at pengutronix.de; l.stach at pengutronix.de; bhelgaas at google.com;
> lorenzo.pieralisi at arm.com; robh at kernel.org; shawnguo at kernel.org;
> vkoul at kernel.org; linux-phy at lists.infradead.org; devicetree at vger.kernel.org;
> linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; kernel at pengutronix.de; dl-linux-imx
> <linux-imx at nxp.com>
> Subject: Re: (EXT) [PATCH v2 0/7] Add the iMX8MP PCIe support
> 
> Hello Richard,
> 
> Am Montag, 7. März 2022, 10:07:27 CET schrieb Richard Zhu:
> > Based on the i.MX8MP GPC and blk-ctrl patch-set[1] issued by Lucas and
> > the following commits.
> >   - one codes refine patch-set[5].
> >   - two Fixes[2],[3].
> >   - one binding commit[4].
> >   - some dts changes in Shawn's git if you want to test PCIe on i.MX8MM
> EVK.
> > b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm
> > evk board aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support
> >     cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support
> >
> > Sorry about that there may be some conflictions when do the codes merge.
> > I'm waiting for the ack now, and will re-base them in a proper
> > sequence later.
> 
> Thanks for providing the dependency list. Unfortunately they did not apply
> without error on my local tree, but this is caused by other patches I track.
> I managed to fix the conflicts, I think.
> Eventually I was able to get a PCIe M.2 ethernet interface working on my
> TQMa8MPxL based board. iperf showed >900MBit/s Tx and > 700 MBit/s Rx.
> Thanks for your effort. Once the depenencies and reviews are settled, you'll get
> my tested-by.
Hi Alexander
It's great that this patch-set works on your board.
Thanks for your help to test it.

Best Regards
Richard Zhu
> 
> Thanks again and regards
> Alexander
> 
> > This series patches add the i.MX8MP PCIe support and tested on i.MX8MM
> > EVK and i.MX8MP EVk boards. The PCIe NVME works fine on both boards.
> >
> > - i.MX8MP PCIe PHY has two resets refer to the i.MX8MM PCIe PHY.
> >   Add one more PHY reset for i.MX8MP PCIe PHY accordingly.
> > - Add the i.MX8MP PCIe PHY support in the i.MX8M PCIe PHY driver.
> >   And share as much as possible codes with i.MX8MM PCIe PHY.
> > - Add the i.MX8MP PCIe support in binding document, DTS files, and PCIe
> >   driver.
> >
> > Main changes v1-->v2:
> > - It's my fault forget including Vinod, re-send v2 after include Vinod
> >   and linux-phy at lists.infradead.org.
> > - List the basements of this patch-set. The branch, codes changes and so on.
> > - Clean up some useless register and bit definitions in #3 patch.
> >
> > [1]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> >
> atchwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Fcover%2F2022022820
> 1
> >
> 73&data=04%7C01%7Chongxing.zhu%40nxp.com%7C5a7b5c3d050242c
> b9aa808d
> >
> a01a26c70%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637824
> 094369636
> >
> 537%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz
> IiLCJBTi
> >
> I6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ZXo1zTOOSxOsGe8IMDr1
> axWcqCnf
> > uL8KAaOdIGk1nxI%3D&reserved=0
> > 1.3330192-1-l.stach at pengutronix.de/
> > [2]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> >
> atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1646289275-17813-
> 1
> >
> -&data=04%7C01%7Chongxing.zhu%40nxp.com%7C5a7b5c3d050242cb9
> aa808da
> >
> 01a26c70%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6378240
> 943696365
> >
> 37%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI
> >
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=K786yDfjsjIV9QpT6Hyawl
> EkQv%2F
> > hQNVBuXk2UU2p%2BXs%3D&reserved=0>
> > git-send-email-hongxing.zhu at nxp.com/
> > [3]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> >
> atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1645672013-8949-1
> -
> >
> g&data=04%7C01%7Chongxing.zhu%40nxp.com%7C5a7b5c3d050242cb
> 9aa808da
> >
> 01a26c70%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6378240
> 943696365
> >
> 37%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI
> >
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Dp2GU3iDuTR91Y6Awqbn
> 0AxPvbBe4
> > %2BtPVvylgzFeWOU%3D&reserved=0
> > it-send-email-hongxing.zhu at nxp.com/
> > [4]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> >
> atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F1646293805-18248-
> 1
> >
> -&data=04%7C01%7Chongxing.zhu%40nxp.com%7C5a7b5c3d050242cb9
> aa808da
> >
> 01a26c70%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6378240
> 943696365
> >
> 37%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI
> >
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hsbURaSevBxxRfus%2Bjre
> Ppo96Oi
> > %2Fel%2BSceueYdIay%2B8%3D&reserved=0>
> > git-send-email-hongxing.zhu at nxp.com/
> > [5]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> >
> atchwork.ozlabs.org%2Fproject%2Flinux-pci%2Fcover%2F1645760667-10510-
> 1
> >
> -&data=04%7C01%7Chongxing.zhu%40nxp.com%7C5a7b5c3d050242cb9
> aa808da
> >
> 01a26c70%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6378240
> 943696365
> >
> 37%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI
> >
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uYwnISUWBSP1yBxe5qfRT
> a%2F9I7y
> > 8YqfyEZXmts5D9Ys%3D&reserved=0>
> > git-send-email-hongxing.zhu at nxp.com/
> >
> > NOTE:
> > Based git
> > <git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git>
> > Based branch <pci/imx6>
> >
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |   1 +
> > Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml |   4 +-
> > arch/arm64/boot/dts/freescale/imx8mp-evk.dts                 |  55
> > ++++++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mp.dtsi
> >         |  46 ++++++++++++++++++-
> drivers/pci/controller/dwc/pci-imx6.c
> >                    |  19 +++++++-
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c                   | 205
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++-----
> >
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++-----
> > ------- drivers/reset/reset-imx7.c                                   |
> 1 +
> > 7 files changed, 286 insertions(+), 45 deletions(-)
> >
> > [PATCH v2 1/7] reset: imx7: Add the iMX8MP PCIe PHY PERST support
> > [PATCH v2 2/7] dt-binding: phy: Add iMX8MP PCIe PHY binding [PATCH v2
> > 3/7] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY [PATCH v2 4/7]
> > dt-bindings: imx6q-pcie: Add iMX8MP PCIe compatible [PATCH v2 5/7]
> > arm64: dts: imx8mp: add the iMX8MP PCIe support [PATCH v2 6/7] arm64:
> > dts: imx8mp-evk: Add PCIe support [PATCH v2 7/7] PCI: imx6: Add the
> > iMX8MP PCIe support
> 
> 
>