[PATCH 6/9] phy: ti: tusb1210: Improve ulpi_read()/_write() error checking

[Andy Shevchenko]

+Cc: Ferry

On Sat, Feb 05, 2022 at 05:45:32PM +0100, Hans de Goede wrote:
> ulpi_read() and ulpi_write() calls can fail. Add wrapper functions to log
> errors when this happens and add error checking to the read + write of
> the phy parameters from the TUSB1210_VENDOR_SPECIFIC2 register.


This patch seems to break Intel Merrifield platform.

Before:

[   36.333644] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[   36.339828] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 1
[   36.352566] xhci-hcd xhci-hcd.1.auto: hcc params 0x0220f06c hci version 0x100 quirks 0x0000000002010010
[   36.367062] xhci-hcd xhci-hcd.1.auto: irq 16, io mem 0xf9100000
[   36.378429] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[   36.384705] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 2

After:
[   32.986776] tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
[   32.994053] phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
[   33.000601] dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
[   33.007486] dwc3: probe of dwc3.0.auto failed with error -110


Any ideas?

P.S> There is no bisect log, since it's done manually with a good guess by
Ferry. I have just reverted patches on ULPI from this series and start applying
them one-by-one.

-- 
With Best Regards,
Andy Shevchenko