[PATCH v2 2/6] phy: samsung: ufs: constify samsung_ufs_phy_cfg

Chanho Park chanho61.park at samsung.com
Thu Jun 2 06:04:15 PDT 2022


> > @@ -75,7 +75,7 @@ static int samsung_ufs_phy_wait_for_lock_acq(struct
> > phy *phy)  static int samsung_ufs_phy_calibrate(struct phy *phy)  {
> >  	struct samsung_ufs_phy *ufs_phy = get_samsung_ufs_phy(phy);
> > -	struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
> > +	const struct samsung_ufs_phy_cfg **cfgs = ufs_phy->cfg;
> 
> This should be rather array of const pointers to const data.

The prototype of ufs_phy->cfg is 'const struct samsung_ufs_phy_cfg **' by this patch.
So, it should be,

const struct samsung_ufs_phy_cfg ** const cfgs = ufs_phy->cfg;

Best Regards,
Chanho Park




More information about the linux-phy mailing list