[PATCH v2 2/2] PCI: dwc: exynos: Correct generic PHY usage
Marek Szyprowski
m.szyprowski at samsung.com
Wed Jul 13 00:21:02 PDT 2022
The proper initialization for generic PHYs is to call first phy_init(),
then phy_power_on().
While touching this, lets remove the phy_reset() call. It is just a
left-over from the obsoleted Exynos5440 support and current exynos-pcie
PHY driver doesn't even support this function. It is also rarely used by
other drivers.
Reported-by: Bjorn Helgaas <helgaas at kernel.org>
Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
Reviewed-by: Chanho Park <chanho61.park at samsung.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
---
drivers/pci/controller/dwc/pci-exynos.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 2044d191fba6..6d0742207f43 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct dw_pcie_rp *pp)
exynos_pcie_assert_core_reset(ep);
- phy_reset(ep->phy);
- phy_power_on(ep->phy);
phy_init(ep->phy);
+ phy_power_on(ep->phy);
exynos_pcie_deassert_core_reset(ep);
exynos_pcie_enable_irq_pulse(ep);
--
2.17.1
More information about the linux-phy
mailing list