[PATCH] phy: bcm-ns-usb2: improve printing ref clk errors

Florian Fainelli f.fainelli at gmail.com
Tue Nov 23 11:04:44 PST 2021


On 11/23/21 1:48 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> Print actual error number to help debugging issues but also avoid
> printing -EPROBE_DEFER.
> 
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> ---
>  drivers/phy/broadcom/phy-bcm-ns-usb2.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> index 98d32729a45d..4cb70785ccb4 100644
> --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c
> @@ -132,8 +132,12 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
>  
>  	usb2->ref_clk = devm_clk_get(dev, "phy-ref-clk");
>  	if (IS_ERR(usb2->ref_clk)) {
> -		dev_err(dev, "Clock not defined\n");
> -		return PTR_ERR(usb2->ref_clk);
> +		int err = PTR_ERR(usb2->ref_clk);

dev_err_probe() should take care of that for you already.
-- 
Florian



More information about the linux-phy mailing list