[PATCH 3/4] PHY: rockchip: USB2: Allow 64 bits reg property
Robin Murphy
robin.murphy at arm.com
Mon Jun 14 10:09:15 PDT 2021
On 2021-06-14 16:43, Benjamin Gaignard wrote:
> In rk356x device-tree "reg" property could be coded on 64 bits.
> Change reg type and of_property_read_ to make it works.
On platforms with #address-cells=1, this isn't going to do what you
think. Worse, it's not even going to fail, because you *can* read a
64-bit value from an address cell with a size cell after it...
Robin.
> Signed-off-by: Peter Geis <pgwipeout at gmail.com>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard at collabora.com>
> ---
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index 46ebdb1460a3d..45518f96d7217 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1068,7 +1068,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
> struct rockchip_usb2phy *rphy;
> const struct rockchip_usb2phy_cfg *phy_cfgs;
> const struct of_device_id *match;
> - unsigned int reg;
> + u64 reg;
> int index, ret;
>
> rphy = devm_kzalloc(dev, sizeof(*rphy), GFP_KERNEL);
> @@ -1098,7 +1098,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
> rphy->usbgrf = NULL;
> }
>
> - if (of_property_read_u32(np, "reg", ®)) {
> + if (of_property_read_u64(np, "reg", ®)) {
> dev_err(dev, "the reg property is not assigned in %pOFn node\n",
> np);
> return -EINVAL;
>
More information about the linux-phy
mailing list