[PATCH v6 1/3] phy: core: Reword the comment specifying the units of max_link_rate to be Mbps

Vinod Koul vkoul at kernel.org
Sun Jun 13 22:50:53 PDT 2021


On 11-06-21, 18:31, Kishon Vijay Abraham I wrote:

> >>> So there are a few users of max_link_rate. It would be better that we
> >>> document all previous users of max_link_rate that unit is in Mbps and
> >>> then modify it here
> >>>
> >>
> >> I was able to see that the max_link_rate attribute was used at,
> >>
> >> drivers/phy/cadence/phy-cadence-torrent.c:2514:
> >> gphy->attrs.max_link_rate = cdns_phy->max_bit_rate;
> >>
> >> and in the bindings there is indication that the units to be used is Mbps.
> >>
> >> Can you please point me if there is any other place that I might have
> >> missed to look at or that might need documentation update?
> >>
> 
> The only user seems to be Torrent and max_bit_rate is documented well in
> Torrent.
> 
> Acked-by: Kishon Vijay Abraham I <kishon at ti.com>

Series Applied, thanks

-- 
~Vinod



More information about the linux-phy mailing list