[PATCH v5 1/2] phy: samsung-ufs: move phy-exynos7-ufs header

[Krzysztof Kozlowski]

On 09/07/2021 19:31, Krzysztof Kozlowski wrote:
> On 09/07/2021 11:45, Chanho Park wrote:
>> Instead of using exynos7 ufs definition in phy-exynos7-ufs.h, we should
>> put it into phy-exynos7-ufs.c to be included different objects or units.
>>
>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
>> Signed-off-by: Chanho Park <chanho61.park at samsung.com>
>> ---
>>  drivers/phy/samsung/Makefile                              | 4 +++-
>>  .../phy/samsung/{phy-exynos7-ufs.h => phy-exynos7-ufs.c}  | 8 ++------
>>  drivers/phy/samsung/phy-samsung-ufs.h                     | 5 ++++-
>>  3 files changed, 9 insertions(+), 8 deletions(-)
>>  rename drivers/phy/samsung/{phy-exynos7-ufs.h => phy-exynos7-ufs.c} (93%)
>>
>> diff --git a/drivers/phy/samsung/Makefile b/drivers/phy/samsung/Makefile
>> index 3959100fe8a2..68518ae30c1b 100644
>> --- a/drivers/phy/samsung/Makefile
>> +++ b/drivers/phy/samsung/Makefile
>> @@ -2,7 +2,9 @@
>>  obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO)	+= phy-exynos-dp-video.o
>>  obj-$(CONFIG_PHY_EXYNOS_MIPI_VIDEO)	+= phy-exynos-mipi-video.o
>>  obj-$(CONFIG_PHY_EXYNOS_PCIE)		+= phy-exynos-pcie.o
>> -obj-$(CONFIG_PHY_SAMSUNG_UFS)		+= phy-samsung-ufs.o
>> +obj-$(CONFIG_PHY_SAMSUNG_UFS)		+= phy-exynos-ufs.o
>> +phy-exynos-ufs-y			+= phy-samsung-ufs.o
>> +phy-exynos-ufs-y			+= phy-exynos7-ufs.o
> 
> How does it support module builds? The previous code was working fine
> when built as module. Maybe I miss something, but I don't see the need
> for this change.

Ah, I see now, your previous patch was creating separate modules. Makes
sens, thanks!

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>


Best regards,
Krzysztof