[PATCH phy 2/6] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation

Marek Behún kabel at kernel.org
Fri Dec 3 12:58:37 PST 2021


On Tue, 23 Nov 2021 12:56:24 +0530
Vinod Koul <vkoul at kernel.org> wrote:

> > +#define COMPHY_SYNC_MASK_GEN_REG	0x25
> > +#define PHY_GEN_MAX_OFFSET		10
> > +#define PHY_GEN_MAX_MASK		(3 << PHY_GEN_MAX_OFFSET)  
> 
> Pls use GENMASK()

Dear Vinor, Pali,

I have refactored this driver thoroughly to kernel standards (without
functional changes) and fixed a lot of register name definitions (they
didn't align with Functional Specification). (I have also prepared
this fixes for TF-A, but will need to rebase them.)

I have also applied one functional change to fix a bug I found, but
still need to fix another bug.

Hopefully I will have a solution tomorrow or on Sunday.

Marek



More information about the linux-phy mailing list