[PATCH 2/4] pcmcia: pd6729: Delete an error message for a failed memory allocation in pd6729_pci_probe()

SF Markus Elfring elfring at users.sourceforge.net
Mon May 15 05:27:58 PDT 2017


From: Markus Elfring <elfring at users.sourceforge.net>
Date: Mon, 15 May 2017 12:44:23 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
 drivers/pcmcia/pd6729.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c
index 289a5e74e852..a723ffbbd691 100644
--- a/drivers/pcmcia/pd6729.c
+++ b/drivers/pcmcia/pd6729.c
@@ -632,7 +632,5 @@ static int pd6729_pci_probe(struct pci_dev *dev,
-	if (!socket) {
-		dev_warn(&dev->dev, "failed to kzalloc socket.\n");
+	if (!socket)
 		return -ENOMEM;
-	}
 
 	ret = pci_enable_device(dev);
 	if (ret) {
-- 
2.13.0




More information about the linux-pcmcia mailing list