[PATCH 18/33] pcmcia: sa1100: provide generic CF support

Linus Walleij linus.walleij at linaro.org
Wed Sep 14 01:52:39 PDT 2016

On Mon, Aug 29, 2016 at 12:25 PM, Russell King
<rmk+kernel at armlinux.org.uk> wrote:

> Provide generic non-voltage sensing socket support for StrongARM
> platforms using the gpiolib and regulator subsystems to obtain the
> resources to control the socket.
> Signed-off-by: Russell King <rmk+kernel at armlinux.org.uk>

> +static int sa11x0_drv_pcmcia_probe(struct platform_device *pdev)
> +{
> +       struct soc_pcmcia_socket *skt;
> +       struct device *dev = &pdev->dev;
> +
> +       if (dev->id == -1)
> +               return sa11x0_drv_pcmcia_legacy_probe(pdev);

There is a typo there, it should be pdev->id rather than dev->id.

After fixing this, my legacy h3600 PCMCIA started probing again.

(It revealed another bug in fetching GPIOs but it is an orthogobal
problem altogether, looking into it.)

Linus Walleij

More information about the linux-pcmcia mailing list