[PATCH] pcmcia: db1xxx_ss: fix last irq_to_gpio user

Manuel Lauss manuel.lauss at gmail.com
Wed Mar 2 01:25:58 PST 2016

On Wed, Mar 2, 2016 at 10:01 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 02 March 2016 09:16:12 Manuel Lauss wrote:
>> remove the usage of removed irq_to_gpio() function.  On pre-DB1200
>> boards, pass the actual carddetect GPIO number instead of the IRQ,
>> because we need the gpio to actually test card status (inserted or
>> not) and can get the irq number with gpio_to_irq() instead.
>> Tested on DB1300 and DB1500, this patch fixes PCMCIA on the DB1500,
>> which used irq_to_gpio().
>> Signed-off-by: Manuel Lauss <manuel.lauss at gmail.com>
> Thanks for addressing this
> Acked-by: Arnd Bergmann <arnd at arndb.de>
> You should probably add the fixes line from my earlier patch,
> and add Cc:stable so it gets backported to 4.4.

Done, will send a v2 soon.

> My first approach was to pass the gpio number as platform_data, but
> that seemed to get rather complicated, so I dropped the initial
> patch.
> Passing it as an IORESOURCE_IRQ is a bit weird too, but I guess it
> gets the job done.

It's not the nicest solution, true, but it gets the job done, and the
driver isn't used outside the old alchemy development boards.
I apparently am the only remaining user of this code with hardware
to test on :)

Thank you!

More information about the linux-pcmcia mailing list