[PATCH] pcmcia: use kstrdup() in pcmcia_device_query()
Geliang Tang
geliangtang at 163.com
Thu Oct 1 09:37:57 PDT 2015
Use kstrdup instead of kmalloc and strncpy.
Signed-off-by: Geliang Tang <geliangtang at 163.com>
---
drivers/pcmcia/ds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 0decee6..489ea10 100644
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -468,12 +468,10 @@ static int pcmcia_device_query(struct pcmcia_device *p_dev)
if ((length < 2) || (length > 255))
continue;
- new = kmalloc(sizeof(char) * length, GFP_KERNEL);
+ new = kstrdup(tmp, GFP_KERNEL);
if (!new)
continue;
- new = strncpy(new, tmp, length);
-
tmp = p_dev->prod_id[i];
p_dev->prod_id[i] = new;
kfree(tmp);
--
2.5.0
More information about the linux-pcmcia
mailing list