[PATCH 3/3] drivers: pcmcia: Include appropriate header file in cardbus.c

Bjorn Helgaas bhelgaas at google.com
Thu Dec 19 13:53:49 EST 2013

On Thu, Dec 19, 2013 at 11:14 AM, Bjorn Helgaas <bhelgaas at google.com> wrote:
> On Thu, Dec 19, 2013 at 1:36 AM, Rashika Kheria
> <rashika.kheria at gmail.com> wrote:
>> Include appropriate header file cs_internal.h in cardbus.c because
>> functions cb_alloc() and cb_free() have their prototype declarations in
>> cs_internal.h.
>> This eliminates the following warnings in cardbus.c:
>> drivers/pcmcia/cardbus.c:67:11: warning: no previous prototype for ‘cb_alloc’ [-Wmissing-prototypes]
>> drivers/pcmcia/cardbus.c:105:6: warning: no previous prototype for ‘cb_free’ [-Wmissing-prototypes]
>> Signed-off-by: Rashika Kheria <rashika.kheria at gmail.com>
>> Reviewed-by: Josh Triplett <josh at joshtriplett.org>
> Applied to my pci/misc branch for v3.14, thanks!

I dropped this for now because it breaks my build:

  CC      drivers/pcmcia/cardbus.o
In file included from drivers/pcmcia/cardbus.c:28:0:
drivers/pcmcia/cs_internal.h:164:9: error: unknown type name ‘cisdata_t’
drivers/pcmcia/cs_internal.h:171:9: error: unknown type name ‘cisdata_t’
drivers/pcmcia/cs_internal.h:171:25: error: unknown type name ‘cisparse_t’
drivers/pcmcia/cs_internal.h:172:28: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:173:7: error: unknown type name ‘cisparse_t’
drivers/pcmcia/cs_internal.h:177:4: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:180:4: error: unknown type name ‘tuple_t’
drivers/pcmcia/cs_internal.h:182:52: error: unknown type name ‘tuple_t’
make[2]: *** [drivers/pcmcia/cardbus.o] Error 1

My .config is attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config
Type: application/octet-stream
Size: 92023 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20131219/71d2ce12/attachment-0001.obj>

More information about the linux-pcmcia mailing list