[PATCH v2 00/16] Clean up drivers/pci/remove.c

[Bjorn Helgaas]

On Mon, Aug 20, 2012 at 8:45 PM, Yijing Wang <wangyijing at huawei.com> wrote:
> On 2012/8/20 23:40, Bjorn Helgaas wrote:
>> On Sun, Aug 19, 2012 at 10:58 PM, Yijing Wang <wangyijing at huawei.com> wrote:
>>> tested-by Yijing Wang <wangyijing at huawei.com>
>>
>> Great, thanks for trying this out!  Can you give me any details on
>> what you tested (what sort of machine, which hotplug driver, PCIe
>> button/LED style hotplug or ExpressCard style, etc?)
>>
>
> Hi Bjorn,
>    I tested these patches in IA_64, and use acpiphp driver to do the hot-plug test.
> The hotplug action was triggered via sysfs interface(/sys/bus/pci/slots/xxx/).
> The target pcie devices were fibre channel card and Intel 82576 card.As bellow:

Thanks, that's perfect!  It's especially good to test acpiphp because
that was one of the "not completely obvious" changes.

I added your Tested-by: to the acpiphp and the PCI core patches; let
me know if that's not what you intended.

> 0000:40:07.0 root port supports hotplug by acpiphp.
> hot plug 0000:46:00.0 and its child devices and buses.
>
> -+-[0000:40]-+-00.0-[0000:41]--
>  |           +-01.0-[0000:42]--+-00.0  Intel Corporation 82576 Gigabit Network Connection
>  |           |                 \-00.1  Intel Corporation 82576 Gigabit Network Connection
>  |           +-03.0-[0000:43]----00.0  LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS
>  |           +-04.0-[0000:44]--
>  |           +-05.0-[0000:45]--
>  |           +-07.0-[0000:46-49]----00.0-[0000:47-49]--+-02.0-[0000:48]--+-00.0  Intel Corporation 82576 Gigabit Network Connection
>  |           |                                         |                 \-00.1  Intel Corporation 82576 Gigabit Network Connection
>  |           |                                         \-04.0-[0000:49]--+-00.0  Intel Corporation 82576 Gigabit Network Connection
>  |           |                                                           \-00.1  Intel Corporation 82576 Gigabit Network Connection
>
> after hot remove
> -+-[0000:40]-+-00.0-[0000:41]--
>  |           +-01.0-[0000:42]--+-00.0  Intel Corporation 82576 Gigabit Network Connection
>  |           |                 \-00.1  Intel Corporation 82576 Gigabit Network Connection
>  |           +-03.0-[0000:43]----00.0  LSI Logic / Symbios Logic SAS1064ET PCI-Express Fusion-MPT SAS
>  |           +-04.0-[0000:44]--
>  |           +-05.0-[0000:45]--
>  |           +-07.0-[0000:46-49]--
>
>
>>>> This started as a simple conversion of list_for_each() to
>>>> list_for_each_entry(), so I could remove the pci_dev_b() helper.
>>>>
>>>> In the process, I noticed that drivers/pci/remove.c is getting a little
>>>> crufty, so I reworked it to make it more understandable.  This is a long
>>>> series of small patches, so it might be easiest to start by looking at the
>>>> end product, so you have some idea where I'm heading.
>
>
>
> --
> Thanks!
> Yijing
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html