[TRIVIAL PATCH 0/3] pcmcia: Make struct pcmcia_device_id const

Dominik Brodowski linux at dominikbrodowski.net
Wed May 11 04:51:34 EDT 2011


On Fri, May 06, 2011 at 11:04:55AM -0700, Joe Perches wrote:
> On Fri, 2011-05-06 at 08:15 +0200, Dominik Brodowski wrote:
> > On Tue, May 03, 2011 at 07:28:59PM -0700, Joe Perches wrote:
> > > Reduces data use.
> > > Staging could be applied now, but additional harmless warnings do result.
> > > Joe Perches (3):
> > >   pcmcia: Make declaration and uses of struct pcmcia_device_id const
> > >   pcmcia: Convert pcmcia_device_id declarations to const
> > >   staging: pcmcia: Convert pcmcia_device_id declarations to const
> > Thanks, applied all three patches to the pcmcia git tree.
> 
> Hi Dominik, just so you're aware...
> 
> By the time your tree gets pushed, there'll likely
> be conflicts with staging changes.

Well, -next doesn't show any issues so far. *knock on wood*

> There are also a couple of uses of pcmcia_device_id
> in sound/ that could be modified.
> 
> $ grep -rPwn --include=*.[ch] pcmcia_device_id sound
> sound/pcmcia/vx/vxpocket.c:353:static struct pcmcia_device_id vxp_ids[] = {
> sound/pcmcia/pdaudiocf/pdaudiocf.c:281:static struct pcmcia_device_id snd_pdacf_ids[] = {
> 
> Here's a patch for those as well

Thanks, applied.

Best,
	Dominik



More information about the linux-pcmcia mailing list