[PATCH] pccardctl: fix segmentation fault on unknown long option

Dominik Brodowski linux at dominikbrodowski.net
Mon Sep 6 05:04:10 EDT 2010


Hello Jirka,

On Mon, Sep 06, 2010 at 10:44:59AM +0200, Jirka Klimes wrote:
> On Saturday 04 of September 2010 12:54:04 Dominik Brodowski wrote:
> > Hello Jirka,
> > 
> > On Tue, Aug 31, 2010 at 04:00:05PM +0200, Jirka Klimes wrote:
> > > calling pccardctl with an unknown long option causes SIGSEGV;
> > > e.g. pccardctl --ver
> > > 
> > > The patch adds missing last zeroed element to options array.
> > 
> > Thanks, nice patch. Could you add a Signed-off-by - line (as per the Linux
> > kernel rules, see Documentation/SubmittingPatches for details), please,
> > then I'll apply it right away?
> > 
> > Thanks and best wishes,
> > 	Dominik
> 
> Calling pccardctl with an unknown long option causes SIGSEGV;
> e.g. pccardctl --ver
> The patch adds missing last zeroed element to options array.
> 
> Signed-off-by: Jirka Klimes <jklimes at redhat.com>
> 
> ---
> 
> Ok, I include the same patch, now with the sign-off.

Many thanks -- it's applied and in the git tree already.

> Thanks Dominik for pointing me to the rules as I'm not much familiar with 
> process. I'm going to get to know it closely.

You're welcome :)

Best,
	Dominik



More information about the linux-pcmcia mailing list