add each PCMCIA-card explicitly to struct pcmcia_device_id?

[Dominik Brodowski]

On Sat, May 08, 2010 at 04:52:05PM +0200, Kristoffer Ericson wrote:
> On Sat, May 08, 2010 at 03:33:53PM +0400, Alexander Kurz wrote:
> > Hi,
> >  I have got some PCMCIA-cards, which are not listed explicitly in 
> >  the according struct pcmcia_device_id list, but are matched by
> >  PCMCIA_DEVICE_FUNC_ID(2) in serial-cs or ...(4) ide-cs.
> >  Everything works fine. Should I regardless of that
> >  send a patch with PCMCIA_DEVICE_MANF_CARD or
> >  PCMCIA_DEVICE_PROD_ID12 entries to match those cards explicitly?
> 
> My first impression is that more is better (=add)

Yes, that's right -- for PCMCIA_DEVICE_FUNC_ID() to work, we need userspace
to be up and running: We only allow func_id matches after userspace has had
a chance to verify there is no module to be loaded with a more exact
prod_id/manf_id/card_id match.

Best,
	Dominik