[RESEND PATCH 4/5] pcmcia/bfin_cf: don't check platform_get_irq's return value against zero
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Wed Jan 13 06:05:45 EST 2010
platform_get_irq returns -ENXIO on failure, so !irq was probably
always true. Better use irq <= 0. Note that a return value of
zero is still handled as error even though this could mean irq0.
This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Cc: David Vrabel <dvrabel at arcom.com>
Cc: Greg Kroah-Hartman <gregkh at suse.de>
Cc: Rafael J. Wysocki <rjw at sisk.pl>
Cc: linux-pcmcia at lists.infradead.org
---
drivers/pcmcia/bfin_cf_pcmcia.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pcmcia/bfin_cf_pcmcia.c b/drivers/pcmcia/bfin_cf_pcmcia.c
index 300b368..2482ce7 100644
--- a/drivers/pcmcia/bfin_cf_pcmcia.c
+++ b/drivers/pcmcia/bfin_cf_pcmcia.c
@@ -205,7 +205,7 @@ static int __devinit bfin_cf_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "Blackfin CompactFlash/PCMCIA Socket Driver\n");
irq = platform_get_irq(pdev, 0);
- if (!irq)
+ if (irq <= 0)
return -EINVAL;
cd_pfx = platform_get_irq(pdev, 1); /*Card Detect GPIO PIN */
--
1.6.6
More information about the linux-pcmcia
mailing list