[PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

Komuro komurojun-mbn at nifty.com
Fri Aug 13 19:59:11 EDT 2010


Hi,

>@@ -248,9 +248,8 @@ static int fmvj18x_probe(struct pcmcia_device *link)
>     lp->base = NULL;
> 
>     /* The io structure describes IO port mapping */
>-    link->io.NumPorts1 = 32;
>-    link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
>-    link->io.IOAddrLines = 5;
>+    link->resource[0]->end = 32;
>+    link->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO;
> 


Do you have any reason to move "link->io_lines = 5" from fmvj18x_probe
to fmvj18x_config?


>@@ -345,6 +344,8 @@ static int fmvj18x_config(struct pcmcia_device *link)
> 
>     dev_dbg(&link->dev, "fmvj18x_config\n");
> 
>+    link->io_lines = 5;
>+
>     len = pcmcia_get_tuple(link, CISTPL_FUNCE, &buf);
>     kfree(buf);
> 



More information about the linux-pcmcia mailing list