[RFC][PATCH] pcmcia: pcnet_cs.c removing useless condition

David Miller davem at davemloft.net
Tue Sep 22 17:17:16 EDT 2009


From: Jaswinder Singh Rajput <jaswinder at kernel.org>
Date: Sun, 13 Sep 2009 00:38:49 +0530

> [This is untested]
> 
> 'if (i < NR_INFO)' will only true if we breaks from 'for (i = 0; i < NR_INFO; i++)'
> So removing useless 'if (i < NR_INFO)'
> 
> This also fixed following compilation warning :
> 
>   CC [M]  drivers/net/pcmcia/pcnet_cs.o
> drivers/net/pcmcia/pcnet_cs.c: In function ‘get_hwinfo’:
> drivers/net/pcmcia/pcnet_cs.c:321: warning: ‘base’ may be used uninitialized in this function
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput at gmail.com>

Looks good to me, applied.


More information about the linux-pcmcia mailing list