[PATCH 16/16] pcmcia: use dev_dbg and dev_print in pd6729.c

[Dominik Brodowski]

On Sun, Oct 25, 2009 at 12:19:25AM +0200, Wolfram Sang wrote:
> On Sat, Oct 24, 2009 at 09:43:06PM +0200, Dominik Brodowski wrote:
> > As suggested by Wolfram Sang <w.sang at pengutronix.de>, use dev_dbg() and
> > dev_printk() in pd6729.c.
> 
> I'd also include dev_err, dev_warn and dev_info :)

What's their advantage?

> >  			if (csc & I365_CSC_DETECT) {
> >  				events |= SS_DETECT;
> > -				dprintk("Card detected in socket %i!\n", i);
> > +				dev_dbg(&socket[i].socket.dev,
> > +					"Card detected in socket %i!\n", i);
> 
> Dunno, in days of dynamic_printk it might be better to skip debug outputs 
> in ISRs, no?

Why?

Best,
	Dominik