[PATCH 14/16] pcmcia: use dynamic debug infrastructure, deprecate CS_CHECK (misc drivers)

Komuro komurojun-mbn at nifty.com
Tue Nov 3 03:15:51 EST 2009


Hi,

> > Also, remove all usages of the CS_CHECK macro and replace them with proper
> > Linux style calling and return value checking. The extra error reporting m
ay
> > be dropped, as the PCMCIA core already complains about any (non-driver-aut
hor)
>> > errors.


If the "extra error reporting" is dropped and debug option is not enabled,
the driver is unloaded without error message.

So it should be

            ret = pcmcia_request_io(link, &link->io);
            if (ret) {
                   dev_err(... pcmcia_request_io failed\n");
                   return ret;
           }

Best Regards
Komuro




More information about the linux-pcmcia mailing list