[PATCH] pcmcia: pxa2xx-sharpsl: check if we do have Scoop config

Dmitry Eremin-Solenikov dbaryshkov at gmail.com
Mon Apr 20 12:58:15 EDT 2009


2009/4/20 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> On Mon, Apr 20, 2009 at 08:01:19PM +0400, Dmitry Eremin-Solenikov wrote:
>> Check if we really have Scoop config, otherwice we can get a nice Oops
>> during probe.
>
> Looks to me like -rc material.  Please submit to the patch tracker with
> your (missing) sign-off.  Thanks.

Done, thanks.

>
>> ---
>>  drivers/pcmcia/pxa2xx_sharpsl.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/pcmcia/pxa2xx_sharpsl.c b/drivers/pcmcia/pxa2xx_sharpsl.c
>> index 1cd02f5..bc43f78 100644
>> --- a/drivers/pcmcia/pxa2xx_sharpsl.c
>> +++ b/drivers/pcmcia/pxa2xx_sharpsl.c
>> @@ -255,6 +255,9 @@ static int __init sharpsl_pcmcia_init(void)
>>  {
>>       int ret;
>>
>> +     if (!platform_scoop_config)
>> +             return -ENODEV;
>> +
>>       sharpsl_pcmcia_ops.nr = platform_scoop_config->num_devs;
>>       sharpsl_pcmcia_device = platform_device_alloc("pxa2xx-pcmcia", -1);
>>
>> --
>> 1.6.2.1
>>
>>
>> -------------------------------------------------------------------
>> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
>> FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
>> Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
>



-- 
With best wishes
Dmitry



More information about the linux-pcmcia mailing list