[PATCH] pcmcia: Fix broken abuse of dev->driver_data

Alan Cox alan at lxorguk.ukuu.org.uk
Mon Sep 22 18:12:27 EDT 2008


> > +	
> 
> trailing whitespace

Nod..

> >  	if (did && (did->match_flags & PCMCIA_DEV_ID_MATCH_DEVICE_NO) &&
> >  	    (p_dev->socket->device_count == 1) && (p_dev->device_no ==
> > 0)) pcmcia_add_device_later(p_dev->socket, 0);
> 
> uh?

Looks like a mailer folded it later, but the patch itself seems just fine.

> >  
> > - put_module:
> > +put_module:
> >  	if (ret)
> >  		module_put(p_drv->owner);
> > - put_dev:
> > +put_dev:
> 
> unrelated -- please do not change it this time.

Not sure you can have it both ways - if you don't want stray whitespace
then fixing the labels to conform to coding style seems to go with it ;)

Alan



More information about the linux-pcmcia mailing list