[PATCH] pcmcia: ensure correct logging in do_io_probe [v2]

[Frans Pop]

On Sunday 09 November 2008, Dominik Brodowski wrote:
> On Fri, Nov 07, 2008 at 03:22:42PM +0100, Frans Pop wrote:
> > During early probing of the parent PCI bridge I/O window no socket
> > has been allocated yet.
> > In that case print &s->cb_dev->dev instead of &s->dev as device.
>
> similar to the other patch, this won't work: &skt->cb_dev is only
> available and set if the parent device is a PCI device; therefore,
> &skt->dev is the only thing we can use.

OK.

I still feel I'm missing something in the debug logging. Shouldn't there 
be a line saying something like the following?
yenta_cardbus 0000:02:06.0: Assigned pcmcia socket 0

> An alternative approach would be to move this initialization code only
> after we've set dev_name. Could you test whether this approach works
> for you, please?

Tested on two different systems: Toshiba Satellite A40 running i386 (with 
atheros wlan card already inserted during boot) and HP 2510p running 
x86_64 (with same card inserted after boot).
Both with patch applied against current mainline git. I've not seen any 
problems and wireless worked in both cases.

There are some differences in the logs (see attachments). I only see the 
IO probes on the Toshiba, not on the HP. I'd guess that's expected.

Tested-by: Frans Pop <elendil at planet.nl>


This does leave one minor issue from my previous patch. Please consider 
applying the attached patch.

Cheers,
FJP

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcmcia_close-prink.patch
Type: text/x-diff
Size: 665 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20081115/dece43c2/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcmcia_hp2510p.log
Type: text/x-log
Size: 591 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20081115/dece43c2/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcmcia_toshiba.log
Type: text/x-log
Size: 923 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20081115/dece43c2/attachment-0002.bin