[KERNEL 2.6.26-rc4] bugreport : pata_pcmcia with Sandisk Extreme III 8GB

[Tejun Heo]

Hello,

Komuro wrote:
> On Sat, 14 Jun 2008 03:20:41 -0400
> Jeff Garzik <jeff at garzik.org> wrote:
> 
> 
> After removing the 3-lines below in ata_eh_reset
> the pata_pcmcia works properly.
> 
> 
> -       spin_lock_irqsave(link->ap->lock, flags);
> -       link->eh_info.serror = 0;
> -       spin_unlock_irqrestore(link->ap->lock, flags);
> 
> Please fix this problem.

Thanks for diagnosing the problem but it doesn't make any sense at all.
 Those three lines just clear cached SError value.  pata_pcmcia being a
PATA driver, SError is not implemented and always zero.

Also the init_one error is -ENOMEM.  For the above change to make any
difference, EH should have been entered which is invoked deep into
ata_host_register() and once control reaches that point it never returns
error code.  I have difficult time imagining any way the above diff can
have anything to do with the reported failure.

Please apply the attached patch and report the log after probe failure.

Thanks.

-- 
tejun
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pata_pcmcia-debug.patch
Type: text/x-patch
Size: 1776 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-pcmcia/attachments/20080616/a9965bff/attachment.bin