[PATCH] : hd64461 pcmcia driver

[Dominik Brodowski]

Hi,

On Thu, May 15, 2008 at 07:26:57PM +0200, Kristoffer Ericson wrote:
> + * COPYRIGHT (C) ?  Greg Banks <gbanks at pocketpenguins.com>
? Just leave it empty if you don't know the year.

> +	/* ??? */
?

> +
> +static int __init init_hd64461_ss(void)
> +{
> +	int i;
> +
> +	printk(KERN_INFO "hd64461 host bridge driver\n");
> +
> +	if (platform_driver_register(&hd64461_pcmcia_driver))
> +		return -ENODEV;
> +
> +	i = hd64461_init_socket(0, HD64461_IRQ_PCC0, HD64461_PCC0_BASE, 0xf000);
> +	if (i < 0)
> +		goto failed2;
> +
> +	hd64461_pcmcia_device = platform_device_alloc("hd64461-pcmcia",-1);
> +	if(!hd64461_pcmcia_device) {
> +		printk(KERN_INFO "hd64461_ss_init: Cannot find pcmcia host device!\n");
> +		return -ENODEV;

In this case, you do not unregister the platform_driver. 

> +static void __exit exit_hd64461_ss(void)
> +{
> +	/* Only remove if there's something to remove */
> +	if (hd64461_pcmcia_device) {
> +		platform_device_unregister(hd64461_pcmcia_device);
> +		platform_driver_unregister(&hd64461_pcmcia_driver);
> +	}

Can't (and don't you have to) unregister the driver unconditionally?

Otherwise, patch looks good; and I'll merge it to the 2.6.26-queue once you
send me an updated patch.

Thanks and best wishes,
	Dominik