[RFC] [PATCH 3/7] pcmcia: use pcmcia_loop_config in bluetooth drivers

Dominik Brodowski linux at dominikbrodowski.net
Wed Jul 30 02:56:52 EDT 2008


Hi Marcel,

On Tue, Jul 29, 2008 at 11:11:33PM +0200, Marcel Holtmann wrote:
> > Use the config loop helper in bluetooth pcmcia drivers.
> > 
> > CC: Marcel Holtmann <marcel at holtmann.org>
> > CC: linux-bluetooth at vger.kernel.org
> > Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
> 
> in general I am okay with these changes, but can we please follow kernel
> coding style. It is "if (...) {". The curly braces are supposed to be on
> the same line. Only for functions the belong on the next line. Sorry for
> being picky here :)

Ah, thanks for noticing this. Fixed the two instances where I got it wrong;
will push the corrected patch upstream (for 2.6.28) then.

Best,
	Dominik



More information about the linux-pcmcia mailing list