On Mon, Jul 14, 2008 at 10:14:12AM +0200, Dominik Brodowski wrote: > if (test_bit(IS_CMM_ABSENT, &dev->flags)) { > DEBUGP(4, dev, "CMM_ABSENT flag set\n"); > - return -ENODEV; > + goto out; > } > + rc = EINVAL; Shouldn't this be rc = -EINVAL; ? //Peter