[PATCH] pcmcia ide-cs: Fix debugging to conform with CONFIG_PCMCIA_DEBUG criteria
Larry Finger
Larry.Finger at lwfinger.net
Fri Jul 11 22:48:54 EDT 2008
The code in module ide-cs does not conform to the current standard if
setting CONFIG_PCMCIA_DEBUG to "y", and loading the module with the
option "pc_debug=N". When that is fixed, then a warning results that
version is defined but not used. This patch fixes both situations.
Signed-off-by: Larry Finger <Larry.Finger at lwfinger.net>
---
Dominick,
This is 2.6.27 material. It is a bug in the current version, but is
hardly worth pushing now.
The patch applies to the current 2.6.26-rc9 tree.
Larry
ide-cs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: wireless-testing/drivers/ide/legacy/ide-cs.c
===================================================================
--- wireless-testing.orig/drivers/ide/legacy/ide-cs.c 2008-07-09 21:11:12.000000000 -0500
+++ wireless-testing/drivers/ide/legacy/ide-cs.c 2008-07-11 10:32:49.000000000 -0500
@@ -63,11 +63,11 @@
#define INT_MODULE_PARM(n, v) static int n = v; module_param(n, int, 0)
-#ifdef PCMCIA_DEBUG
-INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG);
+#ifdef CONFIG_PCMCIA_DEBUG
+INT_MODULE_PARM(pc_debug, 0);
#define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args)
-static char *version =
-"ide-cs.c 1.3 2002/10/26 05:45:31 (David Hinds)";
+/*static char *version =
+"ide-cs.c 1.3 2002/10/26 05:45:31 (David Hinds)";*/
#else
#define DEBUG(n, args...)
#endif
More information about the linux-pcmcia
mailing list