[PATCH 35/39] pcmcia: deprecate CS_BAD_TUPLE

Dominik Brodowski linux at dominikbrodowski.net
Thu Aug 21 17:49:14 EDT 2008


Larry,

On Wed, Aug 20, 2008 at 04:01:54PM -0500, Larry Finger wrote:
> >+    if (ret)
> >+	    cs_dbg(s, 0, "parse_tuple failed %d\n", ret);
> 
> This routine fails to compile with debugging enabled because "s" has 
> never been declared. The fix required adding the socket as an argument 
> for pccard_parse_tuple, which required a change in the wrapper macro, 
> etc. The revised patch is attached.

*doh* However, I propose not to change the definition of
pccard_parse_tuple() for there is no technical requirement. Therefore, I
prefer to use a non-dev_dbg-related debug command here. It's fixed in
pcmcia-git; and will be squashed (along with the cs_internal.h broken #define)
into the patch which broke stuff.

Best,
	Dominik



More information about the linux-pcmcia mailing list