[PATCH 39/39] pcmcia: don't add extra DEBUG cflag bugfix

Larry Finger Larry.Finger at lwfinger.net
Wed Aug 20 15:53:35 EDT 2008


Dominik Brodowski wrote:
> Fix one remaining raw DEBUG usage.
> 
> Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
> ---
>  drivers/pcmcia/ds.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
> index 60bcc3e..ce2a7db 100644
> --- a/drivers/pcmcia/ds.c
> +++ b/drivers/pcmcia/ds.c
> @@ -42,7 +42,7 @@ MODULE_AUTHOR("David Hinds <dahinds at users.sourceforge.net>");
>  MODULE_DESCRIPTION("PCMCIA Driver Services");
>  MODULE_LICENSE("GPL");
>  
> -#ifdef DEBUG
> +#ifdef CONFIG_PCMCIA_DEBUG
>  int ds_pc_debug;
>  
>  module_param_named(pc_debug, ds_pc_debug, int, 0644);

This hunk is no longer needed as the change was moved up to 09/39.

My system uses the following pcmcia-related modules. Everything seems 
to be working.

ide_cs
ide_disk
ide_core
yenta_socket
rsrc_nonstatic
pcnet_cs
pcmcia
pcmcia_core

There is one warning left in the compilations, namely

   CC [M]  drivers/pcmcia/cardbus.o
include/asm/io_32.h: In function ‘memcpy_fromio’:
include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’ 
discards qualifiers from pointer target type

I don't know how to get rid of it, but I'll look for your fix.

Larry




More information about the linux-pcmcia mailing list