[PATCH 04/39] pcmcia: use pcmcia_loop_config in bluetooth drivers

Marcel Holtmann marcel at holtmann.org
Mon Aug 18 15:57:11 EDT 2008


Hi Dominik,

> Use the config loop helper in bluetooth pcmcia drivers.
> 
> CC: Marcel Holtmann <marcel at holtmann.org>
> CC: linux-bluetooth at vger.kernel.org
> Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>

I know that the Bluetooth PCMCIA drivers are not the best examples for
coding style, but please double check your whitespaces/tabs. We don't
wanna make it worse.

> -	return get_tuple(handle, tuple, parse);
> +        unsigned long try = (unsigned long) priv_data;
> +
> +       if (cf->vpp1.present & (1 << CISTPL_POWER_VNOM))
> +               p_dev->conf.Vpp = cf->vpp1.param[CISTPL_POWER_VNOM] / 10000;

This is an obvious case where something is wrong.

Regards

Marcel





More information about the linux-pcmcia mailing list