[PATCH] fix parallel build of ccdv

Dominik Brodowski linux at dominikbrodowski.net
Tue Aug 12 17:39:14 EDT 2008


Thanks for spotting this issue! Could I get your Signed-off-by: for this
patch too, please? (then I'll apply it both to cpufrequtils and pcmciautils,
for both suffer from the same issue).

Thanks!

	Dominik

On Tue, Aug 12, 2008 at 11:24:30AM +0200, Olivier Blin wrote:
> Parallel build was broken because ccdv was not necessarily built
> before the object files were built (occured with make -j4).
> ---
>  Makefile |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index cc30ae4..e1d7c85 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -208,11 +208,12 @@ UDEV_RULES += udev/rules-end
>  
>  all: ccdv $(PCCARDCTL) $(PCMCIA_CHECK_BROKEN_CIS) $(PCMCIA_SOCKET_STARTUP_BUILD) udevrules
>  
> -ccdv:
> +ccdv: build/ccdv
> +build/ccdv: build/ccdv.c
>  	@echo "Building ccdv"
> -	@$(HOSTCC) -O1 build/ccdv.c -o build/ccdv
> +	@$(HOSTCC) -O1 $< -o $@
>  
> -.c.o:
> +%.o : %.c ccdv
>  	$(QUIET) $(CC) $(CFLAGS) -c -o $@ $<
>  
>  %.c %.h : %.y
> -- 
> 1.5.6.4
> 
> 
> _______________________________________________
> Linux PCMCIA reimplementation list
> http://lists.infradead.org/mailman/listinfo/linux-pcmcia



More information about the linux-pcmcia mailing list