[Bug 10500] nozomi: kernel BUG()s when card is removed

[bugme-daemon at bugzilla.kernel.org]

http://bugzilla.kernel.org/show_bug.cgi?id=10500





------- Comment #1 from oleg at tv-sign.ru  2008-04-23 10:00 -------
Created an attachment (id=15864)
 --> (http://bugzilla.kernel.org/attachment.cgi?id=15864&action=view)
test patch: add flush_workqueue() to tty_exit()

Well, I don't understand this code at all, but since nobody answers...

Evgeni, could you try this patch to see if it makes any difference?

In any case, nozomi.c:tty_exit() does something strange with workqueues,


        tty_exit:

                flush_scheduled_work();
Why?
                if (dc->port[i].tty && list_empty(->hangup_work.entry)
                        tty_hangup(dc->port[i].tty);

I guess list_empty() means "this work is not queued". We have
work_pending(work) for that. But why do we need this check at all?
tty_hangup()->schedule_work() will fail if work_struct is queued.

Oleg.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.