[2.6 patch] PCMCIA mustn't select HAVE_IDE
bunk at kernel.org
Tue Apr 15 17:23:26 EDT 2008
On Tue, Apr 15, 2008 at 10:15:34PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Monday 14 April 2008, Sam Ravnborg wrote:
> > On Mon, Apr 14, 2008 at 05:16:59PM +0300, Adrian Bunk wrote:
> > > It's plain wrong for PCMCIA to select HAVE_IDE that implies e.g. the
> > > availability of an asm/ide.h
> > >
> > > Signed-off-by: Adrian Bunk <bunk at kernel.org>
> > >
> > > ---
> > > 9cdb66112488bc0c6e1d528444d3ba30d5b0487f diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> > > index 8b22281..519b4ff 100644
> > > --- a/drivers/pcmcia/Kconfig
> > > +++ b/drivers/pcmcia/Kconfig
> > > @@ -38,7 +38,6 @@ config PCMCIA_DEBUG
> > > config PCMCIA
> > > tristate "16-bit PCMCIA support"
> > > select CRC32
> > > - select HAVE_IDE
> > > default y
> > I did this when introducing HAVE_IDE.
> > But I do not recall why and the rationale for removing it
> > seems fine to me.
> IIRC it was needed for some arm platforms which don't select HAVE_IDE
> explicetely but I don't know if this is still the case, pinging Russell.
It's definitely bogus since it can cause compile breakage on
architectures like avr32.
And whatever it should have fixed should be fixed properly.
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
More information about the linux-pcmcia